Yair Zaslavsky has posted comments on this change.
Change subject: core: add permission for changing custom properties
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
I agree with your comment about the suggested code reuse.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 1074: public List<PermissionSubject> getPermissionCheckSubjects() {
thanks for clarifying.
--
To view, visit http://gerrit.ovirt.org/5492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7409927233901439e33ec31c1091dd5948953e7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
