Greg Padgett has uploaded a new change for review. Change subject: engine: fix exception in coco.removeAllCommandsInHierarchy ......................................................................
engine: fix exception in coco.removeAllCommandsInHierarchy Prevent a ConcurrentModificationException when removing command hierarchies. Change-Id: I8608e3ea0e0970fe70cf5fa7718560c80728f2b6 Signed-off-by: Greg Padgett <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/28730/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java index 390bb2c..558815e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java @@ -124,7 +124,7 @@ } public void removeAllCommandsInHierarchy(final Guid commandId) { - for (Guid childCmdId : getChildCommandIds(commandId)) { + for (Guid childCmdId : new ArrayList<Guid>(getChildCommandIds(commandId))) { removeAllCommandsInHierarchy(childCmdId); } removeCommand(commandId); -- To view, visit http://gerrit.ovirt.org/28730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8608e3ea0e0970fe70cf5fa7718560c80728f2b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
