Gilad Chaplik has posted comments on this change. Change subject: db, core: Introduce BaseProfile and DiskProfile ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/27099/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java: Line 34: PROVIDER(24, "Provider"), Line 35: GlusterService(25, "GlusterService"), Line 36: ExternalTask(26, "ExternalTask"), Line 37: VnicProfile(27, "Vnic Profile"), Line 38: DiskProfile(30, "Disk Profile"); > why not 28 ? Done Line 39: Line 40: private int value; Line 41: private String vdcObjectTranslationVal; Line 42: private static final Map<Integer, VdcObjectType> map = new HashMap<Integer, VdcObjectType>(values().length); http://gerrit.ovirt.org/#/c/27099/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java: Line 131: // audit log management action group Line 132: AUDIT_LOG_MANAGEMENT(1304, RoleType.ADMIN, false), Line 133: Line 134: // affinity group CRUD commands Line 135: MANIPULATE_AFFINITY_GROUPS(1550, RoleType.ADMIN, true, ApplicationMode.VirtOnly), > please add a space line Done Line 136: // disk profiles Line 137: CONFIGURE_STORAGE_DISK_PROFILE(1560, RoleType.ADMIN, true, ApplicationMode.VirtOnly), Line 138: CREATE_STORAGE_DISK_PROFILE(1561, RoleType.ADMIN, true, ApplicationMode.VirtOnly), Line 139: DELETE_STORAGE_DISK_PROFILE(1562, RoleType.ADMIN, true, ApplicationMode.VirtOnly); http://gerrit.ovirt.org/#/c/27099/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/BaseProfilesDaoFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/BaseProfilesDaoFacadeImpl.java: Line 23: * @param rs Line 24: * @return specific mapper for derived profile dao Line 25: * @throws SQLException Line 26: */ Line 27: protected abstract T createPartialProfileEntity(ResultSet rs) throws SQLException; > I guess this file should be changed according to the Qos feedbacks. Done Line 28: Line 29: /** Line 30: * @param map Line 31: * @param obj -- To view, visit http://gerrit.ovirt.org/27099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229af59277b5055453188f002f19046cdd51d63b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
