Maor Lipchuk has posted comments on this change.

Change subject: core: fixed assign quota to disks in register vm
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/28745/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java:

Line 93:             }
Line 94:         }
Line 95:     }
Line 96: 
Line 97:     private ArrayList<DiskImage> getImages(Map<Guid, Disk> diskMap) {
please rename to getDiskImageListFromDisksMap
Line 98:         return new ArrayList<>(LinqUtils.foreach(diskMap.values(), new 
Function<Disk, DiskImage>() {
Line 99:             @Override
Line 100:             public DiskImage eval(Disk disk) {
Line 101:                 return (DiskImage) disk;


-- 
To view, visit http://gerrit.ovirt.org/28745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id885420281e4b01a3116eed3684e3dac70b6ec30
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to