Tomas Jelinek has posted comments on this change. Change subject: frontend: VirtIO RNG device in instance types ......................................................................
Patch Set 2: Code-Review+2 (1 comment) seems good, needs to wait until it's dependency get in. http://gerrit.ovirt.org/#/c/28691/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java: Line 401: maybeSetEntity(model.getIsSmartcardEnabled(), vmBase.isSmartcardEnabled()); Line 402: maybeSetEntity(model.getIsSingleQxlEnabled(), vmBase.getSingleQxlPci()); Line 403: } Line 404: Line 405: private <T> void maybeSetSelectedItem(ListModel<T> listModel, T value) { thanx for making it generic! Line 406: if (listModel != null && listModel.getIsChangable() && listModel.getIsAvailable()) { Line 407: listModel.setSelectedItem(value); Line 408: } Line 409: } -- To view, visit http://gerrit.ovirt.org/28691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d4eadff40f9a855d9ad8a1c42909d0ae7dfc09a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
