Yair Zaslavsky has posted comments on this change. Change subject: core: WIP: Adding JPA to ovirt ......................................................................
Patch Set 15: (4 comments) http://gerrit.ovirt.org/#/c/22806/15/backend/manager/modules/common/pom.xml File backend/manager/modules/common/pom.xml: Line 61: <groupId>javax.annotation</groupId> Line 62: <artifactId>javax.annotation-api</artifactId> Line 63: <version>1.2</version> Line 64: </dependency> Line 65: > Based on persistence.xml (contains the JPA version) really ? and you don't need to download a different jar? (i,e diffferent version)... or is it because its provided by jboss? but even if provided with jboss, i would have expected the jar to have a 2.x version or something. maybe not this one... Line 66: </dependencies> Line 67: Line 68: <build> Line 69: <plugins> http://gerrit.ovirt.org/#/c/22806/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Securityid.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Securityid.java: Line 1: package org.ovirt.engine.core.common.businessentities; Line 2: Line 3: import java.io.Serializable; Line 4: Line 5: import javax.persistence.Column; > We can use an internal class. You think it's better? Hmm, please explain your suggestion? Line 6: Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public class Securityid implements Serializable { http://gerrit.ovirt.org/#/c/22806/15/backend/manager/modules/dal/pom.xml File backend/manager/modules/dal/pom.xml: Line 86: </dependency> Line 87: <dependency> Line 88: <groupId>javax.persistence</groupId> Line 89: <artifactId>persistence-api</artifactId> Line 90: <version>1.0.2</version> > Done cool, ignore my previous comments in the different pom :) Line 91: </dependency> Line 92: </dependencies> Line 93: <build> Line 94: <filters> http://gerrit.ovirt.org/#/c/22806/15/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 63 Line 64 Line 65 Line 66 Line 67 > That would be impossible to manage... care to explain why do u think so? -- To view, visit http://gerrit.ovirt.org/22806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd0bbf9f0913955cb3e1facfa9a4bdc1f1ab24d Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
