Gilad Chaplik has posted comments on this change. Change subject: core: Introducing runInternalXXX at CommandBase ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28820/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 218: return getBackend().runInternalAction(commandType, params, rollbackContext); Line 219: } Line 220: return new VdcReturnValueBase(); Line 221: } Line 222: > can be private? just looked, I guess that there are a few more methods that you need to encapsulate. Line 223: protected BackendInternal getBackend() { Line 224: return Backend.getInstance(); Line 225: } Line 226: -- To view, visit http://gerrit.ovirt.org/28820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7f3a3283836325eca72f9db3cc3115861a2d555 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: liron aravot <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
