Alon Bar-Lev has posted comments on this change. Change subject: engine: Configure unique host name on neutron.conf ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/28791/6//COMMIT_MSG Commit Message: Line 21: So the engine should be able to define a unique host name for each Line 22: agent, first for the agent which reports its name to the neutron node, Line 23: and later-on when port are allocated on each agent. Line 24: Line 25: Since the host name is unique, and could be changed only by - Line 26: re-installing the host, it makes sense to use it as the agent name. Line 27: Line 28: Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec Line 22: agent, first for the agent which reports its name to the neutron node, Line 23: and later-on when port are allocated on each agent. Line 24: Line 25: Since the host name is unique, and could be changed only by Line 26: re-installing the host, it makes sense to use it as the agent name. Just to make sure... again... sorry I bother, but this is non standard... 1. what if host is ip address? is it valid? 2. what if host is added, then removed from engine then renamed and another host is added by the same name? then you have two services running with same "name". 3. can we use the unique id of host for example? just want to make sure... we know what we are doing... sorry. Line 27: Line 28: Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec -- To view, visit http://gerrit.ovirt.org/28791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
