Liran Zelkha has posted comments on this change. Change subject: core,restapi: removed separator inconsistency.. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28343/4/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java: Line 76: putReturnType(map, VmPool.class, "Pools"); Line 77: putReturnType(map, Event.class, "Events"); Line 78: putReturnType(map, GlusterVolume.class, "Volumes"); Line 79: putReturnType(map, Disk.class, "Disks"); Line 80: putReturnType(map, Network.class, "Networks"); > Liran The same holds for both my comments - what's actually entered to the map is not the value that you see in the code, but something that is concatenated, at some other point, which makes it confusing. But that's a matter of personal opinion I guess. Line 81: Line 82: return Collections.unmodifiableMap(map); Line 83: } Line 84: -- To view, visit http://gerrit.ovirt.org/28343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c72e0527f084e1453da7f720a23fe84dd94db6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
