Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: setup: write answer file also on error ......................................................................
packaging: setup: write answer file also on error previously answer file was not written if an error occurred at customization or if user did not accept configuration preview. Also the answer file was not updated with late values asket at closeup stage if an error occurred in that stage. Now the answer file is always written, also on error, allowing to user to run again setup without providing all the answers again. Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca Bug-Url: https://bugzilla.redhat.com/1107772 Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup refs/changes/56/28856/1 diff --git a/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py b/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py index d2bd87a..44e434d 100644 --- a/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py +++ b/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py @@ -91,13 +91,13 @@ self._save_answers() @plugin.event( - stage=plugin.Stages.STAGE_CLOSEUP, + stage=plugin.Stages.STAGE_CLEANUP, priority=plugin.Stages.PRIORITY_LAST, condition=lambda self: self.environment[ ohostedcons.CoreEnv.ANSWER_FILE ] is not None ) - def _save_answers_at_closeup(self): + def _save_answers_at_cleanup(self): self._save_answers() self.logger.info( _("Answer file '{name}' has been updated").format( -- To view, visit http://gerrit.ovirt.org/28856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
