Omer Frenkel has uploaded a new change for review.

Change subject: core: NPE on UpdateVmVersion call to GetVmPayloadQuery
......................................................................

core: NPE on UpdateVmVersion call to GetVmPayloadQuery

some changes in the session mgmt caused a NPE on the call to
GetVmPayloadQuery from UpdateVmVersionCommand.
The NPE caused because the session isn't automatically copied to the
query, so in this patch it is manually set in the query params.

Change-Id: If0a0a5cf79a6eb7967ed4ae4454a763773b23d65
Signed-off-by: Omer Frenkel <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/28862/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
index def4672..a209834 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
@@ -164,8 +164,9 @@
         }
 
         if (!StringUtils.isEmpty(getParameters().getSessionId())) {
-            VmPayload payload = 
getBackend().runInternalQuery(VdcQueryType.GetVmPayload,
-                    new IdQueryParameters(getVmTemplateId())).getReturnValue();
+            IdQueryParameters p = new IdQueryParameters(getVmTemplateId());
+            p.setSessionId(getParameters().getSessionId());
+            VmPayload payload = 
getBackend().runInternalQuery(VdcQueryType.GetVmPayload, p).getReturnValue();
 
             if (payload != null) {
                 addVmParams.setVmPayload(payload);


-- 
To view, visit http://gerrit.ovirt.org/28862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0a0a5cf79a6eb7967ed4ae4454a763773b23d65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to