Hello Sandro Bonazzola,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/28900

to review the following change.

Change subject: packaging: setup: write answer file also on error
......................................................................

packaging: setup: write answer file also on error

previously answer file was not written if an error occurred
at customization or if user did not accept configuration preview.
Also the answer file was not updated with late values asked at
closeup stage if an error occurred in that stage.
Now the answer file is always written.

Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca
Bug-Url: https://bugzilla.redhat.com/1055497
Signed-off-by: Sandro Bonazzola <[email protected]>
Signed-off-by: Yedidyah Bar David <[email protected]>
---
M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup 
refs/changes/00/28900/1

diff --git a/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py 
b/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py
index 96cd94d..0b47eb4 100644
--- a/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py
+++ b/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py
@@ -52,7 +52,7 @@
         )
 
     @plugin.event(
-        stage=plugin.Stages.STAGE_VALIDATION,
+        stage=plugin.Stages.STAGE_CLEANUP,
         priority=plugin.Stages.PRIORITY_LAST,
         condition=lambda self: self.environment[
             ohostedcons.CoreEnv.ANSWER_FILE


-- 
To view, visit http://gerrit.ovirt.org/28900
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to