Yair Zaslavsky has posted comments on this change. Change subject: aaa: Adding engineSessionId on CommandContext ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/28829/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java: Line 145: public ExecutionContext getExecutionContext() { Line 146: return executionContext; Line 147: } Line 148: Line 149: public CommandContext setLock(EngineLock lock) { > is this class going to be persisted? if so, is it ok to have setter method Not going to be persisted, AFAIK. How can you persist execution context, compensation context? engineSessionId will not survive engine restart. Line 150: this.lock = lock; Line 151: return this; Line 152: } Line 153: -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
