Ravi Nori has uploaded a new change for review. Change subject: engine : if setSucceeded(true) is called before exception command is presented as succeeded ......................................................................
engine : if setSucceeded(true) is called before exception command is presented as succeeded if any Command calls: getReturnValue().setSucceeded(true); and after that follows some logic, then if this logic fails, outcome of this command will be presented as successful. Compensation/rollbacks etc. are called, but data sent to user is wrong. Change-Id: Iee7b186314dacdeeb818c6fdf5157876b0b8342e Bug-Url: https://bugzilla.redhat.com/1106464 Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/28916/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 64cf761..c530e2b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -1137,6 +1137,7 @@ } finally { // If we failed to execute due to exception or some other reason, we compensate for the failure. if (exceptionOccurred || !getSucceeded()) { + setSucceeded(false); compensate(); } else { cleanUpCompensationData(); -- To view, visit http://gerrit.ovirt.org/28916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee7b186314dacdeeb818c6fdf5157876b0b8342e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
