Yaniv Bronhaim has posted comments on this change. Change subject: hooks: add post-upgrade script ......................................................................
Patch Set 2: (1 comment) I would comment more about the file name and constant for the path, and the commit message but first lets settle the argument and agree to go with this approach http://gerrit.ovirt.org/#/c/28917/2/hooks/post-upgrade/01-vdsm File hooks/post-upgrade/01-vdsm: Line 2: Line 3: # We should reconfigure vdsm after upgrade, /var/lib/vdsm/reconfigure Line 4: # will trigger it Line 5: touch /var/lib/vdsm/reconfigure Line 6: persist /var/lib/vdsm/reconfigure > call vdsmd with force parameter but it runs the configure with old version, it will config the conf files with the old version parameters, how does it help?? Alon, we have no way to upgrade the conf files before running with the upgraded version of vdsm code, we must perform this call after first boot and we have 2 option how to do that: by vdsm as we suggested in this patch (touching a file that will be recognized by vdsm on first boot), or having "first boot after upgrade" hook in ovirt-node code itself that will trigger it. we don't have such hook in ovirt-node, and if we'll create one it also be an hack only for this issue. so after considering it with doron and fabian we claim that using the post-upgrade script to persist file that will be recognized by vdsm is not a bad idea. this the only solution we could came up with without too many odd changes that will ensure that after upgrade vdsm will configure itself properly. -- To view, visit http://gerrit.ovirt.org/28917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5793802d5917354f0ff49d879721239b58709737 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
