Alona Kaplan has posted comments on this change. Change subject: userportal,webadmin: Revert Tooltip infrastructure ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/28872/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java: Line 46: (!"". Please change to !StringUtils.isEmpty(title) Line 69: setText > Should be- setTitle(text.asString()) not setText. Also, why not do anything if it is null? Please change to- setTitle(text == null ? null : text.asString()); -- To view, visit http://gerrit.ovirt.org/28872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I282d7e855d167e02a68b7a2b3807e20c6b78acba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
