Sandro Bonazzola has posted comments on this change. Change subject: reports: remove war file for new db ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28653/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 83: dst = '%s.%s' % (src, suffix) Line 84: self._restore.append(dict(src=src, dst=dst)) Line 85: os.rename(src, dst) Line 86: else: Line 87: dst=None missing spaces around operator = Line 88: self._restore.append(dict(src=src, dst=dst)) Line 89: Line 90: if not self._parent.environment[ Line 91: oreportscons.DBEnv.NEW_DATABASE -- To view, visit http://gerrit.ovirt.org/28653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabf039c1ba864a1f3b7d84443e1bc4538919e6fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
