Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: avoid asking about engine configuration during upgrade ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28956/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py: Line 61: if not self.environment[oenginecons.EngineDBEnv.NEW_DATABASE]: Line 62: # we are upgrading from 3.4 that doesn't ask about it Line 63: # but we need to upgrade the engine cause has been configured Line 64: # in the past Line 65: # It can be removed in future release ( > 3.5) I think we should keep it. I'm not sure we should support partial upgrade. Also if we're upgrading from 3.5 alpha to beta, I think we should upgrade everything installed by previous engine setup. Line 66: self.environment[oenginecons.CoreEnv.ENABLE] = True Line 67: else: Line 68: self.environment[ Line 69: oenginecons.CoreEnv.ENABLE -- To view, visit http://gerrit.ovirt.org/28956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0f6ac38c748e332336ddc1c05ec7d8b4df6014 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
