Einav Cohen has posted comments on this change.

Change subject: webadmin: cluster equals
......................................................................


Patch Set 1:

(1 comment)

see inline comment. 

in addition:

- this patch currently depends on an outdated version of 
http://gerrit.ovirt.org/#/c/28872. A simple rebase ('git fetch origin; git 
rebase origin/master') and pushing again should solve this problem. 

- please make sure to add the relevant maintainers to this patch (maybe same 
ones from http://gerrit.ovirt.org/#/c/25593/)

thanks

http://gerrit.ovirt.org/#/c/28957/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-06-19 11:17:48 -0400
Line 4: Commit:     Alexander Wels <[email protected]>
Line 5: CommitDate: 2014-06-19 11:17:48 -0400
Line 6: 
Line 7: webadmin: cluster equals
worth replacing the 'webadmin:' with 'core:' as this is a backend/common change.
Line 8: 
Line 9: - Fixed cluster equals to return true when two clusters are
Line 10:   actually equals. This causes loading indicators to show on
Line 11:   automatic refreshes.


-- 
To view, visit http://gerrit.ovirt.org/28957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab51ef7ac2e456988b640378d3ab0ea98039af7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to