Allon Mureinik has posted comments on this change. Change subject: core: use updated storage allocation validation ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28945/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java: Line 417: protected boolean isStorageDomainWithinThresholds(StorageDomain storageDomain) { Line 418: return validate(new StorageDomainValidator(storageDomain).isDomainWithinThresholds()); Line 419: } Line 420: Line 421: protected boolean doesStorageDomainHasSpaceForRequest(StorageDomain storageDomain, List<DiskImage> disksList) { grammar: doesStorageDomainHaveSpaceForRequest Line 422: StorageDomainValidator storageDomainValidator = createStorageDomainValidator(storageDomain); Line 423: return validate(storageDomainValidator.hasSpaceForClonedDisks(disksList)); Line 424: } Line 425: -- To view, visit http://gerrit.ovirt.org/28945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I886967b7c2dadbbd301eadbea0c7eac9992aba08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
