Alon Bar-Lev has posted comments on this change. Change subject: hooks: Add hook for ovirt-node boot ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28962/2/hooks/on-boot/01-vdsm-configure File hooks/on-boot/01-vdsm-configure: Line 1: #!/bin/sh Line 2: Line 3: vdsm-tool is-configured &> /dev/null Line 4: retval=$? Line 5: if [ "${retval}" -ne 0 ]; then should be: if ! vdsm-tool is-configured &> /dev/null; then vdsm-tool configure --force &> /dev/null fi any reason why we do not allow the output? Line 6: vdsm-tool configure --force &> /dev/null -- To view, visit http://gerrit.ovirt.org/28962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I793d21768c103547cd8082e5353c074245c54535 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
