Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding engineSessionId on CommandContext ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/28829/17//COMMIT_MSG Commit Message: Line 15: b. runInternalQuery will create a query context based on engine context. Line 16: Line 17: c. Modification of runIternalAction and runInternalMultipleActions to pass the command context. Line 18: Line 19: d. Fix of various tests accordingly please also modify commit message. core: introduce context pattern top level commands and queries create context, this context is inherited by every command that is executed within the scope of the top level commands. this approach enables inheritance of security context, correlation id, and any other data that should be kept execution. the end result is eliminating the usage of ThreadLocal usage, which have many disadvantages and should be avoided almost by any cost. For example, leaving data on a thread that is re-used and inherits security context, or the inability to keep context when using complex patterns. Line 20: Line 21: Topic: AAA Line 22: Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
