Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: adding jboss.cer to the list of file to 
uninstall
......................................................................


Patch Set 1:

Note that there are many pki files that are not removed on cleanup. Do:

 engine-setup
 engine-cleanup
 cp -a /etc/pki /some/backup
 engine-setup
 engine-cleanup
 diff -ubr /some/backup /etc/pki

Not sure there is much point in dealing with specific random files for now. We 
keep on saying we should rewrite pki - we should add proper cleanup to the list 
of things to do there... Do we have a bug to track this?

I also thought a bit and not sure what we intend to do when we finally fix 
partial cleanup - currently we have one cleanup group for pki, but we probably 
want to allow e.g. removing wsp or reports with their pki and leave the engine 
working.

-- 
To view, visit http://gerrit.ovirt.org/28991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf8300b7b0b5030856e7e3b2a0c5d6a9dc009c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to