Tal Nisan has posted comments on this change. Change subject: core: Replaced returning null to throwing exception ......................................................................
Patch Set 2: (2 comments) Idan, you marked as verified, did you check it via the cli also to see that the error is propagated correctly to the user? http://gerrit.ovirt.org/#/c/29033/2//COMMIT_MSG Commit Message: Line 7: core: Replaced returning null to throwing exception Line 8: Line 9: The getUserRequestForStorageDomainRepoFileList method used to return Line 10: null when the storage domain was not valid. Line 11: Now it throws a VdcBLLException with GetIsoListError type instead. I think you should explain in the message why this change was needed in the first place Line 12: Line 13: Change-Id: I3e6dc6fbe03ffba94cff8821b35eacf062e42362 Line 14: Related-To: https://bugzilla.redhat.com/918949 Line 10: null when the storage domain was not valid. Line 11: Now it throws a VdcBLLException with GetIsoListError type instead. Line 12: Line 13: Change-Id: I3e6dc6fbe03ffba94cff8821b35eacf062e42362 Line 14: Related-To: https://bugzilla.redhat.com/918949 You have a redundant space here after the colons -- To view, visit http://gerrit.ovirt.org/29033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e6dc6fbe03ffba94cff8821b35eacf062e42362 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
