Yair Zaslavsky has posted comments on this change. Change subject: core: always attempt to clear tasks without vdsm id ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28951/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 331: } else { Line 332: getReturnValue().setCanDoAction(false); Line 333: } Line 334: } finally { Line 335: freeLockExecute(); > Ravi, Liron, Ravi has a point here. IMHO, the reason you think everything is ok, is because you did not restarted engine in the middle of creation. This is why we created async tasks place holders in the beginning. I think that for a scenario where the tasks are created synchronously, there is no issue - parent command creates children commands and they create the vdsm tasks. However, we are now intoducing a mechanism that will allow you to invoke commands asynchrously (please consult with Arik who needs to run destory vm in asynchronous way). In that case, you might end up removing the entries prematurely. Line 336: clearAsyncTasksWithOutVdsmId(); Line 337: } Line 338: return getReturnValue(); Line 339: } -- To view, visit http://gerrit.ovirt.org/28951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib98e90eb3e078761b9ad9d0a30b21c9db20bd7d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
