Liron Aravot has posted comments on this change. Change subject: core: avoid connect to the same target multiple times ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29035/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java: Line 360: Line 361: Line 362: protected static final String LUN_ID1= "1IET_00180001"; Line 363: Line 364: protected static final String LUN_ID2= "1IET_00180003"; > Please add javadoc to both of these. I think there's no really meaning for the java doc here as it doesn't give any further info that might be helpful. see for example IMAGE_GROUP_ID/IMAGE_GROUP_ID_2 that are also without java doc..in that case the name seems self explanatory to me, what do you think? Line 365: Line 366: /** Line 367: * Predefined boot LUN disk attached to VM_RHEL5_POOL_57 Line 368: */ -- To view, visit http://gerrit.ovirt.org/29035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If40ef468dc4eca4237ad824dc81aa39a90cce017 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
