Allon Mureinik has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation ......................................................................
Patch Set 4: Verified-1 (1 comment) http://gerrit.ovirt.org/#/c/28605/4/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3115: String ACTION_TYPE_FAILED_VIRT_IO_SCSI_INTERFACE_FOR_LUN_DISKS_DOES_NOT_SUPPORT_READ_ONLY_ATTR(); Line 3116: Line 3117: @DefaultStringValue("Cannot ${action} ${type}. Memory size exceeds supported limit for given cluster version.") Line 3118: String ACTION_TYPE_FAILED_MEMORY_EXCEEDS_SUPPORTED_LIMIT(); Line 3119: This TWS breaks the build (checkstyle). Line 3120: @DefaultStringValue("Cannot ${action} ${type}. The following storage connections ${connectionIds} cannot be added to the specified iSCSI bond.\n" + Line 3121: "Possible reasons:\n" + Line 3122: "- They are not of type iSCSI.\n" + Line 3123: "- Their status is not one of the following: Unknown, Active. Inactive.\n" + -- To view, visit http://gerrit.ovirt.org/28605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
