Alon Bar-Lev has uploaded a new change for review. Change subject: bll: LoginBaseCommand cleanup: findbugs issues ......................................................................
bll: LoginBaseCommand cleanup: findbugs issues it actually found one old bug... Topic: AAA Change-Id: Ia82aed06df510d0f4d4b5c062cf5543f94372f74 Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/29052/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java index ea503c8..2f1e554 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java @@ -148,7 +148,7 @@ if (profile == null) { log.errorFormat( "Can't login because authentication profile \"{1}\" doesn't exist.", - profile + getParameters().getProfileName() ); addCanDoActionMessage(VdcBllMessages.USER_FAILED_TO_AUTHENTICATE); return false; @@ -377,7 +377,6 @@ password )); - String principal = outputMap.<String> get(Authn.InvokeKeys.PRINCIPAL); int authResult = outputMap.<Integer>get(Authn.InvokeKeys.RESULT); if (authResult != Authn.AuthResult.SUCCESS) { log.infoFormat( -- To view, visit http://gerrit.ovirt.org/29052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia82aed06df510d0f4d4b5c062cf5543f94372f74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
