Liron Aravot has posted comments on this change. Change subject: core: Force detach a storage domain ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29021/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java: Line 49: // Storage pool id can be empty Line 50: DetachStorageDomainVDSCommandParameters detachParams = Line 51: new DetachStorageDomainVDSCommandParameters(getVds().getStoragePoolId(), Line 52: getParameters().getStorageDomainId(), Line 53: Guid.Empty, > Up until now, AFAIK, it could only be called on an empty SD. there's no harm, but it's unneeded (and also requires spm..opposed to before as it seems), see comment further on. Line 54: 0); Line 55: detachParams.setForce(true); Line 56: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.DetachStorageDomain, detachParams); Line 57: if (!returnValue.getSucceeded()) { -- To view, visit http://gerrit.ovirt.org/29021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie75293678ab08616208128ac157426d3d98c1b77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
