Gilad Chaplik has posted comments on this change.

Change subject: core: New internal command, VmSlaPolicyCommand
......................................................................


Patch Set 5:

* what about migrate?

* should we pass all sla limit in this command? what about 
storage/network(future)/memory(future) flows. it seems that a lot of flows 
should call this commands, didn't look at the code, but you want that each of 
the flow will check the QoS was changed? or this logic should reside in the 
command itself. since a lot of flows will call this command, maybe we need 
somekind of a scheduled task for it (just an idea).

-- 
To view, visit http://gerrit.ovirt.org/27646
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to