Ravi Nori has uploaded a new change for review. Change subject: webadmin: inconsistent tooltips in webadmin login page ......................................................................
webadmin: inconsistent tooltips in webadmin login page tooltips shown on textboxes for username and password when you try to login with missing username and password have different design The textbox has a tooltip specified where as password box is missing one. This leads to inconsistent tooltips for password through out webadmin Change-Id: Ia7f93082b1590f28efdb1a8f9a26951f896c7468 Bug-Url: https://bugzilla.redhat.com/1111241 Signed-off-by: Ravi Nori <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelPasswordBox.java 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/29080/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelPasswordBox.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelPasswordBox.java index b95ab58..55b921f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelPasswordBox.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelPasswordBox.java @@ -5,12 +5,14 @@ import com.google.gwt.text.shared.Parser; import com.google.gwt.text.shared.Renderer; import com.google.gwt.user.client.ui.ValueBoxBase; +import org.ovirt.engine.ui.common.widget.TooltipPanel; import org.ovirt.engine.ui.common.widget.editor.EditorWidget; public class EntityModelPasswordBox<T> extends ValueBoxBase<T> implements EditorWidget<T, ValueBoxEditor<T>> { private ObservableValueBoxEditor<T> editor; + private final TooltipPanel tooltipPanel = new TooltipPanel(true, this); public EntityModelPasswordBox(Renderer<T> renderer, Parser<T> parser) { super(Document.get().createPasswordInputElement(), renderer, parser); @@ -24,4 +26,8 @@ return editor; } + @Override + public void setTitle(String text) { + tooltipPanel.setText(text); + } } -- To view, visit http://gerrit.ovirt.org/29080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7f93082b1590f28efdb1a8f9a26951f896c7468 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
