Moti Asayag has uploaded a new change for review. Change subject: engine: Fix coverity complaints ......................................................................
engine: Fix coverity complaints CID 1223023 (#1 of 1): Dereference null return value (NULL_RETURNS) null_method_call: Calling a method on null object getImages(). Change-Id: I0c7a46f47332eee74e1d93df92de8c873b853430 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/29103/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java index 4ef008b..ae39190 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java @@ -157,12 +157,15 @@ return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_OVF_CONFIGURATION_NOT_SUPPORTED); } - for (DiskImage image : getImages()) { - setStorageDomainId(image.getStorageIds().get(0)); - if (!validate(new StorageDomainValidator(getStorageDomain()).isDomainExistAndActive())) { - return false; + if (getImages() != null) { + for (DiskImage image : getImages()) { + setStorageDomainId(image.getStorageIds().get(0)); + if (!validate(new StorageDomainValidator(getStorageDomain()).isDomainExistAndActive())) { + return false; + } } } + if (!getStorageDomain().getStorageDomainType().isDataDomain()) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_UNSUPPORTED, String.format("$domainId %1$s", getParameters().getStorageDomainId()), -- To view, visit http://gerrit.ovirt.org/29103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0c7a46f47332eee74e1d93df92de8c873b853430 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
