Eli Mesika has posted comments on this change. Change subject: core: Recover kdumping host after engine restart ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28932/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java: Line 189: // wait the quiet time from engine start in which we skip fencing operations : int mSecToWait = Config.<Integer>getValue(ConfigValues.DisableFenceAtStartupInSec) * 1000; : ThreadUtils.sleep(mSecToWait); As this is now copied , worth encapsulating in a method Line 199: for (VDS host : hosts) { Line 200: final FenceVdsActionParameters params = new FenceVdsActionParameters( Line 201: host.getId(), Line 202: FenceActionType.Restart Line 203: ); Why there is a need to run a thread inside a thread or you just want all commands to run concurrently ? Line 204: ThreadPoolUtil.execute(new Runnable() { Line 205: @Override Line 206: public void run() { Line 207: Backend.getInstance().runInternalAction( -- To view, visit http://gerrit.ovirt.org/28932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc815a113a703c96cdbe52f28da732f13e96085d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
