Moti Asayag has posted comments on this change. Change subject: core: MacPool related Commands ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/28705/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java: Line 46: Line 47: final MacPoolDAO macPoolDao = getDbFacade().getMacPoolDao(); Line 48: final Guid macPoolId = getParameters().getId(); Line 49: final MacPool macPool = macPoolDao.get(macPoolId); Line 50: final int dcUsageCount = macPoolDao.getDCUsageCount(macPoolId); this call should be moved after the if block, so if the mac pool isn't exist, no need to check the DC usage of it. Line 51: Line 52: if (macPool == null) { Line 53: addCanDoActionMessage(VdcBllMessages.MAC_POOL_DOES_NOT_EXIST); Line 54: return false; -- To view, visit http://gerrit.ovirt.org/28705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0c3657e3e53699bcafa375befdce848b01a2f3 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
