Arik Hadas has posted comments on this change. Change subject: core: fix run internal query ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29107/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2151: } Line 2152: Line 2153: Line 2154: protected VdcQueryReturnValue runInternalQuery(VdcQueryType type, VdcQueryParametersBase queryParams) { Line 2155: queryParams.setSessionId(getParameters().getSessionId()); > Well, did you see the big big context patch?:) I see you're discussion with alon there.. so I think we should decide whether we do it in a similar way for commands & queries as alon suggests there, and then we don't need this patch, or not Line 2156: return getBackend().runInternalQuery(type, queryParams); Line 2157: } Line 2158: -- To view, visit http://gerrit.ovirt.org/29107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6416784def3c398e2ab9b8f15300218482b16d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
