Michael Kublin has posted comments on this change. Change subject: core: move/copy disk entity id fix ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java Line 57: this(containerId, imageGroupId, imageId, storageDomainId, operation); I suppose it intention to overwrite entityId, which was set to imageId at constructor? Code becomes illogical -- To view, visit http://gerrit.ovirt.org/5644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I286a474ac033f980c8d57618f1637032fa22297a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
