Maor Lipchuk has posted comments on this change. Change subject: core: Adding SANState for Storage Domain Static ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/29145/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java: Line 44: private boolean containsUnregisteredEntities; Line 45: Line 46: private String storagePoolName; Line 47: Line 48: private SANState SANState; > please change the name to be different than the type, it's confusing and un done Line 49: Line 50: private transient long lastTimeUsedAsMaster; Line 51: Line 52: public StorageDomainStatic() { Line 163: public void setComment(String value) { Line 164: comment = value; Line 165: } Line 166: Line 167: public SANState getSANState() { > please add to the hashCode and equals to comply with the other members here done Line 168: return SANState; Line 169: } Line 170: Line 171: public void setSANState(SANState sANState) { -- To view, visit http://gerrit.ovirt.org/29145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044676a8707846a51e9028dc67410d3ee944c747 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
