Liron Aravot has posted comments on this change. Change subject: core: Adding OVF utils ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29147/4/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java: Line 52: ovfEntityData.setEntityId(entityId); Line 53: return ovfEntityData; Line 54: } Line 55: Line 56: public static List<OvfEntityData> getOvfEntities(byte[] tarByte, Guid storageDomainId) { consider to rename tarByte to tar when you rebase..tarByte is weird Line 57: List<OvfEntityData> ovfEntityDataFromTar = new ArrayList<>(); Line 58: InputStream is = new ByteArrayInputStream(tarByte); Line 59: Line 60: Map<String, String> filesFromTar; -- To view, visit http://gerrit.ovirt.org/29147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f36ccf2f865d11ef3baa1908346aa3aab1857d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
