Alon Bar-Lev has posted comments on this change.

Change subject: core: introduce context pattern
......................................................................


Patch Set 37:

(1 comment)

http://gerrit.ovirt.org/#/c/28829/37/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java:

Line 597:         getVmStaticDAO().incrementDbGeneration(getVmTemplateId());
Line 598:         for (VdcActionParametersBase p : 
getParameters().getImagesParameters()) {
Line 599:             
Backend.getInstance().endAction(VdcActionType.CreateImageTemplate,
Line 600:                     p,
Line 601:                     
getContext().duplicate().resetCompensationContext().resetExecutionContext().resetLock());
> you can either: 
now I get it! sorry, I thought there was logic change request.
Line 602:         }
Line 603:         if (reloadVmTemplateFromDB() != null) {
Line 604:             endDefaultOperations();
Line 605:         }


-- 
To view, visit http://gerrit.ovirt.org/28829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to