Martin Peřina has posted comments on this change. Change subject: kdump: Check for crashkernel param ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29183/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 105: for line in f: Line 106: if 'crashkernel=' in line: Line 107: crashkernel = True Line 108: break Line 109: except (IOError, OSError): > yes, if there is a failure in so basic open, we need to be aware of it, pro Done Line 110: self.logger.debug( Line 111: 'Error detecting crashkernel parameter', Line 112: exc_info=True, Line 113: ) -- To view, visit http://gerrit.ovirt.org/29183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83efd12c8763f2336506fa61c34c38d7fc9bfe8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
