Liron Aravot has posted comments on this change. Change subject: core: Adding support for TarInMemoryExport ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29039/4/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/OutMemoryTar.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/OutMemoryTar.java: Line 28: byte[] content = new byte[(int) tarEntry.getSize()]; Line 29: Line 30: // Read file from the archive into byte array. Line 31: try (InputStream is = new FileInputStream(tarEntry.getFile());) { Line 32: is.read(content); > no those are part of the process to get the file you read the data in line 39, creating a new string and put into the map isn't related to this Line 33: fileData = new String(content); Line 34: fileToContent.put(tarEntry.getName(), fileData); Line 35: } Line 36: } -- To view, visit http://gerrit.ovirt.org/29039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fbc12337c16baca4be8a82d4a51b8b3ab0af4a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
