Yair Zaslavsky has posted comments on this change. Change subject: core: introduce context pattern ......................................................................
Patch Set 40: (1 comment) http://gerrit.ovirt.org/#/c/28829/40/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java: Line 48: return this; Line 49: } Line 50: Line 51: public CommandContext withoutCompensationContext() { Line 52: return withCompensationContext(new DefaultCompensationContext()); > shouldn't it be Good catch! Both of us are wrong :) but thanks to you, i found the issue. Look at CommandBase.handleTransactivity - what we should have is withoutCompensationContext setting to null- then, we will move the decision of what compensation to set (Default or NoOp) to command base. Once again, thanks! Line 53: } Line 54: Line 55: public CompensationContext getCompensationContext() { Line 56: return compensationContext; -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
