Liron Aravot has posted comments on this change. Change subject: core: Change GetStorageDomainInfo return value ......................................................................
Patch Set 8: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/29146/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java: Line 80: returnValue.setFirst(sdStatic); Line 81: Guid storagePoolId = null; Line 82: String[] poolUUIDs = (String[])xmlRpcStruct.get("pool"); Line 83: if (poolUUIDs != null) { Line 84: storagePoolId = Guid.createGuidFromString(poolUUIDs[0]); you can just setSecond here instead. Line 85: } Line 86: returnValue.setSecond(storagePoolId); Line 87: return returnValue; Line 88: } -- To view, visit http://gerrit.ovirt.org/29146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ca10fd579b6588d57b7ce590e424ee0f8cf75e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
