Alona Kaplan has posted comments on this change. Change subject: webadmin: Interface dialog- when opening the labels scroll should be down ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28884/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java: Line 29: Line 30: @Override Line 31: protected void onLoad() { Line 32: super.onLoad(); Line 33: scrollPanel.scrollToBottom(); > Maybe this can be solved in a more generic fashion, as other widgets extend Regarding the generic issue- I"ll try to change it to more generic solution. Regarding the on load- scrollToBottom() can be performed just after the widget and all its related chain is attached to the dom. The reason for this is that just after the widget is attached and all its and it parents styles are applied a scroll is added (if needed). In NicLabelWidget the items are set before the widget is attached to the dom so 'scrollToBottom' in 'onLoad' is enough. In more general approach 'scrollToBottom' should also be called on items changed event (if the widget is attached and visible). Line 34: } Line 35: Line 36: @Override Line 37: protected NicLabelEditor createWidget(ListModel<String> value) { -- To view, visit http://gerrit.ovirt.org/28884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
