Juan Hernandez has posted comments on this change. Change subject: packaging: Updated default encryption key size to 2048 ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/conf/ca/CreateReq.sh Line 47: keytool -certreq -keystore ./.keystore -storepass $PASS -alias $ALIAS -file requests/$5.req If we are sure that the other option isn't used I would then remove the parameter and update the usage text and the installCA.sh script so it doesn't pass 1 as first option. Otherwise this leftovers will make things difficult to understand for the next person to work on this code. -- To view, visit http://gerrit.ovirt.org/4389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf749134b31665659475c5ef8d8670f88c10bab6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
