Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: Disabled type suggest boxes are not fully filled ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28990/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java: Line 124: Line 125: @Override Line 126: public void setEnabled(boolean enabled) { Line 127: asTextBox().setEnabled(enabled); Line 128: if (enabled) { > Wouldn't it make more sense to add/remove a style class instead of hard cod you are right, this was not the best approach - fixed completely differently. Line 129: asTextBox().getElement().getStyle().setBackgroundColor("#ffffff"); //$NON-NLS-1$ Line 130: } else { Line 131: // the default background of the textbox is not the same as our disabled color Line 132: asTextBox().getElement().getStyle().setBackgroundColor("#e5e5e5"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/28990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic26a695aa127f36023b4e0de01919613280ae960 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
