Martin Peřina has posted comments on this change. Change subject: kdump: Fix kexec-tools detection in node ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/29283/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 112: if self.environment[odeploycons.VdsmEnv.OVIRT_NODE]: Line 113: # in node rpm -q has to be called to get kexec-tools version Line 114: # instead of standard packager Line 115: available = [] Line 116: rpmCmd = self.command.get('rpm', optional=True) > I could not find an answer if since 3.0 we can use rpm, I think we cannot. 1) I verified that RPM works in 3.4/3.5 oVirt nodes (and Fabian confirmed it should work) 2) If rpm doesn't work, we don't get any version, so kdump detection won't be enabled 3) We don't know yet what oVirt node version will be included in oVirt 3.5 4) We don't know if required kexec-tools package will be available in oVirt 3.5 node So IMO using rpm is the best option we have for now. Line 117: if rpmCmd is not None: Line 118: (rc, stdout, stderr) = self.execute( Line 119: ( Line 120: self.command.get('rpm'), Line 119: ( Line 120: self.command.get('rpm'), Line 121: '-q', Line 122: '--qf', Line 123: "\{'version':'%{VERSION}', 'release':'%{RELEASE}'\}", > for version you could just print a simple %{VERSION}-%{RELEASE} and parse t Done Line 124: self._KEXEC_TOOLS_PKG Line 125: ), Line 126: raiseOnError=False Line 127: ) Line 140: else: Line 141: available = self.packager.queryPackages( Line 142: patterns=(self._KEXEC_TOOLS_PKG,), Line 143: ) Line 144: return available > please move all this into the ovirt node plugin. Well, we need to detect required kexec-tools also for non node hosts, so isn't it better to have version detection in one place? Line 145: Line 146: def _update_kdump_conf( Line 147: self, Line 148: content, -- To view, visit http://gerrit.ovirt.org/29283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136469c35e7fc11d3eb89ab5b4fc71395010f42b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
