Daniel Erez has uploaded a new change for review. Change subject: core: fix search of SDs when filtered by host ......................................................................
core: fix search of SDs when filtered by host Following change-id: I862873171c6753f8c8863c10c336e981e39dc8cb, searching storage domains by an host looks like [1]. I.e. the left outer join is being made on the storage_pool_id; which leads to multiple records of the same storage domain (since a data-center can contain multiple hosts). Therefore, reverted to previous search so it looks like [2]. I.e. the join is being made on the storage domain id, hence, ensuring a distinct result set. [1] SELECT storage_domains_for_search.* FROM storage_domains_for_search LEFT OUTER JOIN vds_with_tags ON storage_domains_for_search.storage_pool_id=vds_with_tags.storage_pool_id WHERE vds_with_tags.vds_name ILIKE 'host1') ORDER BY storage_name ASC [2] SELECT storage_domains_for_search.* FROM storage_domains_for_search LEFT OUTER JOIN vds_with_tags ON storage_domains_for_search.id=vds_with_tags.storage_id WHERE vds_with_tags.vds_name ILIKE 'host1') ORDER BY storage_name ASC Change-Id: I04e37501b29a17a634e31e8875d63577e5f9f401 Bug-Url: https://bugzilla.redhat.com/1113891 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/29365/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java index 5141c46..c63833a 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java @@ -109,9 +109,9 @@ // vds - storage domain addJoin(SearchObjects.VDS_OBJ_NAME, - "storage_pool_id", + "storage_id", SearchObjects.VDC_STORAGE_DOMAIN_OBJ_NAME, - "storage_pool_id"); + "id"); // cluster - storage domain addJoin(SearchObjects.VDC_CLUSTER_OBJ_NAME, -- To view, visit http://gerrit.ovirt.org/29365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I04e37501b29a17a634e31e8875d63577e5f9f401 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
