Alon Bar-Lev has posted comments on this change. Change subject: aaa: adding correlation Id arguments at IrsBroker and VdsBroker This is the first patch towards removing corelation id from ThreadLocal. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29366/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 311: Line 312: @Override Line 313: public Object sendRequest(XmlRpcRequest pRequest) throws XmlRpcException { Line 314: return super.sendRequest(new CustomXmlRpcRequest(pRequest)); Line 315: } > Well, are we going to suppport xml rpc in the future? yes, because of that it is not that important, although here you could have do this per request and have it working for all. not blocking anything. Line 316: Line 317: }; Line 318: Line 319: /** -- To view, visit http://gerrit.ovirt.org/29366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I828ad7a6e6ba64ed59bd935f500a9ed008244d6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
