Daniel Erez has uploaded a new change for review. Change subject: core: import glance image - update destinationImage status ......................................................................
core: import glance image - update destinationImage status Following change-id I37eba72dabb17c5ff4c9edaca899f206440791d0, ImportRepoImageCopyTaskHandler -> endSuccessfully/endWithFailure: ImageStatus should be updated according to 'destinationImageId' (as it is saved in entity_snapshot for compensation). Change-Id: I350de04cffba44ce1e394179305824d4ccaf544c Bug-Url: https://bugzilla.redhat.com/1101541 Bug-Url: https://bugzilla.redhat.com/1102785 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/29412/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java index e341457..952c939 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java @@ -98,9 +98,8 @@ attachDiskToTemplate(newTemplateId); } } - getEnclosingCommand().getParameters().getDiskImage().setImageStatus(ImageStatus.OK); ImagesHandler.updateImageStatus( - getEnclosingCommand().getParameters().getDiskImage().getImageId(), ImageStatus.OK); + getEnclosingCommand().getParameters().getDestinationImageId(), ImageStatus.OK); getEnclosingCommand().getReturnValue().setSucceeded(true); } @@ -157,9 +156,8 @@ @Override public void endWithFailure() { super.endWithFailure(); - getEnclosingCommand().getParameters().getDiskImage().setImageStatus(ImageStatus.ILLEGAL); ImagesHandler.updateImageStatus( - getEnclosingCommand().getParameters().getDiskImage().getImageId(), ImageStatus.ILLEGAL); + getEnclosingCommand().getParameters().getDestinationImageId(), ImageStatus.ILLEGAL); } @Override -- To view, visit http://gerrit.ovirt.org/29412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I350de04cffba44ce1e394179305824d4ccaf544c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
